Wireshark-commits: [Wireshark-commits] master-1.10 d38f510: [iSCSI] Fix incorrect heuristic.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 7 Oct 2014 20:55:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d38f5105b4ee461c7b1fa514e5559be099a33636
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

d38f510 by Anish Bhatt (anish@xxxxxxxxxxx):

    [iSCSI] Fix incorrect heuristic.
    
    The only valid check for Expected Data Transfer Length is :
    R and W	 MUST  NOT both be 0 when the Expected Data Transfer Length and/or
    Bidirectional Read Expected Data Transfer Length are not 0
    
    Backported with manual intervention from I5503a5ad524c4e237b143696fc8eda895bcb9172
    with change to reflect v1.10 version of packet-isci.c code.
    
    Ping-Bug: 10469
    
    Change-Id: I56362010f354dac4a5e15978a288104fce2629af
    Reviewed-on: https://code.wireshark.org/review/4529
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  9cfdfdf   [Automatic manuf, services and enterprise-numbers update for 2014-10-05]
    adds  d38f510   [iSCSI] Fix incorrect heuristic.


Summary of changes:
 epan/dissectors/packet-iscsi.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)