Wireshark-commits: [Wireshark-commits] master 9128e43: tcp: default no-subdissector-on-error to TRU

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 6 Oct 2014 15:22:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9128e43745bbb1ba48b031a862a952b093aa9e76
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9128e43 by Evan Huus (eapache@xxxxxxxxx):

    tcp: default no-subdissector-on-error to TRUE
    
    Dissectors that need this set break badly when it isn't. Dissectors which don't
    need this set will still generally be understandable without it, since e.g.
    retransmissions will link to the original packet at the TCP layer, and
    presumably the subdissector payload is exactly the same in that case.
    
    Change-Id: I2871c2a90c601637bdfb8cffaa34a7407995c603
    Ping-Bug: 10525
    Ping-Bug: 10289
    Reviewed-on: https://code.wireshark.org/review/4487
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  47de5a1   Expand dissection of 8.108 Presence Reporting Area Action.
    adds  9128e43   tcp: default no-subdissector-on-error to TRUE


Summary of changes:
 epan/dissectors/packet-tcp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)