Wireshark-commits: [Wireshark-commits] master 94c47b1: mrcpv2: don't use an uninitialized buffer as

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 29 Sep 2014 00:12:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94c47b12b0de4c8f7439d93a37485df296667ff7
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

94c47b1 by Evan Huus (eapache@xxxxxxxxx):

    mrcpv2: don't use an uninitialized buffer as a string
    
    I have no idea what the original intent was with this magical
    otherwise-totally-unused buffer, but it clearly serves no purpose now. Stop
    reading garbage from it, and just read the data in the packet which is what the
    field name suggests.
    
    Bug: 10510
    Change-Id: I05d0b98c04e59ea70247811168c4c8a64861f43d
    Reviewed-on: https://code.wireshark.org/review/4352
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  9683518   Pass the global capture options to open_capture_device().
    adds  94c47b1   mrcpv2: don't use an uninitialized buffer as a string


Summary of changes:
 epan/dissectors/packet-mrcpv2.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)