Wireshark-commits: [Wireshark-commits] master 28ec9c2: PIDL (DCERPC winreg): enhance dissector

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 28 Sep 2014 16:41:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=28ec9c29ea079805d5605f43cc8177198f4d6ffc
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

28ec9c2 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    PIDL (DCERPC winreg): enhance dissector
    
    * Fix PIDL generator for NOEMIT Element (fix -Wunused-function for DCERPC winreg dissector)
    * Fix indent (use tabs)
    * Remove DCERPC winreg dissector from DIRTY list
    
    Change-Id: I5d16cbfe8481a5e5f7e5df9b51735c93ae4375a7
    Reviewed-on: https://code.wireshark.org/review/4322
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e759d82   PIDL: fix -Wmissing-prototype
    adds  28ec9c2   PIDL (DCERPC winreg): enhance dissector


Summary of changes:
 epan/CMakeLists.txt                        |    3 ++-
 epan/dissectors/Makefile.common            |    6 ++++--
 epan/dissectors/packet-dcerpc-winreg.c     |   18 +++---------------
 epan/dissectors/pidl/winreg.cnf            |    9 +++------
 tools/pidl/lib/Parse/Pidl/Wireshark/NDR.pm |    1 +
 5 files changed, 13 insertions(+), 24 deletions(-)