Wireshark-commits: [Wireshark-commits] master-1.12 34a6fc3: Set err_info if the attempts to read re

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Sep 2014 18:02:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=34a6fc3bf90cd9e04048b73a3fec7684fe3c62fc
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

34a6fc3 by Guy Harris (guy@xxxxxxxxxxxx):

    Set err_info if the attempts to read record headers fail.
    
    If it fails due to, for example, the file being gzipped and having a bad
    gzip CRC, the error returned is WTAP_ERR_DECOMPRESS and, for that error,
    err_info is expected to be set to a string giving details of the
    problem, so we need to pass back to our caller the string in question.
    
    Bug: 10484
    Change-Id: If1d959a2c17c92efe282469e1a374bf21561ec14
    Reviewed-on: https://code.wireshark.org/review/4202
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  76c3193   Don't assert that values fit in 32 bits if the NDR64 flag is set.
    adds  34a6fc3   Set err_info if the attempts to read record headers fail.


Summary of changes:
 wiretap/libpcap.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)