Wireshark-commits: [Wireshark-commits] master af9d2df: Don't try to set the length, end, or text of

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 14 Sep 2014 18:41:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=af9d2dfa134eecf420fa5a9589e032db2909fe0d
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

af9d2df by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Don't try to set the length, end, or text of a faked item.
    
    If we try we may (in the case of setting the length or end) mistakenly assert
    out.
    
    Bug: 10329
    Change-Id: I52083ba17f6427712a6a363f48f1f7ae51f2b74b
    Reviewed-on: https://code.wireshark.org/review/4093
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  36ddf54   Revert "Only fake an item by returning 'tree' if they use the same TVB"
    adds  af9d2df   Don't try to set the length, end, or text of a faked item.


Summary of changes:
 epan/proto.c |   31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)