Wireshark-commits: [Wireshark-commits] master-1.10 ffa8d1b: Work around an apparent bug in GtkFileC

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 4 Sep 2014 02:52:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ffa8d1b7a0f3c7413097d4c8456996533f105e8e
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

ffa8d1b by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Work around an apparent bug in GtkFileChooserButton.
    
    It looks like some versions of GTK+ intialize GtkFileChooserButton with a
    location set to NULL and crash when you select an item from the dropdown
    menu. Make sure we have a valid location set in that case.
    
    Change-Id: If2556ef939b95d8af12581a7116a48fb46586f57
    Ping-Bug: 10434
    Reviewed-on: https://code.wireshark.org/review/3977
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 5e3a8fa85201b7f886ad41b85e6cf8c9eca4a978)
    Reviewed-on: https://code.wireshark.org/review/3979
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  9540da5   Don't print the packet counter when capturing if we're also printing packet information to a terminal (which we assume is the same terminal as the one to which the packet counts are being printed), as they get in the way of each other.
    adds  ffa8d1b   Work around an apparent bug in GtkFileChooserButton.


Summary of changes:
 ui/gtk/uat_gui.c |   12 ++++++++++++
 1 file changed, 12 insertions(+)