Wireshark-commits: [Wireshark-commits] master c1325e8: Check whether the hop-count of most inner me

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 3 Sep 2014 11:18:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c1325e8378001c616e323e01ff90e5f53e208117
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c1325e8 by Jérôme LAFORGE (jerome.laforge@xxxxxxxxx):

    Check whether the hop-count of most inner message is equal to 0
    
    Extract RFC3315 about relay message and hop-count :
    
    20.1.1. Relaying a Message from a Client
    
       If the relay agent received the message to be relayed from a client,
       the relay agent places a global or site-scoped address with a prefix
       assigned to the link on which the client should be assigned an
       address in the link-address field.  This address will be used by the
       server to determine the link from which the client should be assigned
       an address and other configuration information.  The hop-count in the
       Relay-forward message is set to 0.
    
    20.3. Construction of Relay-reply Messages
    
       A server uses a Relay-reply message to return a response to a client
       if the original message from the client was relayed to the server in
       a Relay-forward message or to send a Reconfigure message to a client
       if the server does not have an address it can use to send the message
       directly to the client.
    
       A response to the client MUST be relayed through the same relay
       agents as the original client message.  The server causes this to
       happen by creating a Relay-reply message that includes a Relay
       Message option containing the message for the next relay agent in the
       return path to the client.  The contained Relay-reply message
       contains another Relay Message option to be sent to the next relay
       agent, and so on.  The server must record the contents of the
       peer-address fields in the received message so it can construct the
       appropriate Relay-reply message carrying the response from the
       server.
    
       For example, if client C sent a message that was relayed by relay
       agent A to relay agent B and then to the server, the server would
       send the following Relay-Reply message to relay agent B:
    
       msg-type:       RELAY-REPLY
       hop-count:      1
       link-address:   0
       peer-address:   A
       Relay Message option, containing:
         msg-type:     RELAY-REPLY
         hop-count:    0
         link-address: address from link to which C is attached
         peer-address: C
         Relay Message option: <response from server>
    
    Change-Id: I774cc22c9c090af1a5d3732115c7cd3478343288
    Bug:10437
    Reviewed-on: https://code.wireshark.org/review/3936
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  798b1e1   Actually use the define of custom plugins...
    adds  c1325e8   Check whether the hop-count of most inner message is equal to 0


Summary of changes:
 epan/dissectors/packet-dhcpv6.c |   57 +++++++++++++++++++++++++--------------
 1 file changed, 37 insertions(+), 20 deletions(-)