[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dfc005adb248bd5f46ffbc983f85fa8dcf5a2c0b
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

dfc005a by Peter Wu (peter@xxxxxxxxxxxxx):

    Hack to fix RTP player progress line position
    
    PortAudio seems to return 0 as value for Pa_GetStreamTime() on
    a PulseAudio system using the ALSA host API. This is known for 3 years,
    but still has not been fixed. As this function basically gives us a
    monotonically increasing clock in seconds as double, just use the Glib
    library function for that. I don't know whether this adds much latency,
    but it is certainly better than breaking the progress line (and also
    the related auto-scroll).
    
    While at it, split the idx calculation and explain what each part does
    and add modelines. Remove invalid _U_ annotations.
    
     [1]: http://music.columbia.edu/pipermail/portaudio/2011-June/012452.html
    
    Bug: 10307
    Change-Id: I67fff531e0577add4b9b76052e286fb3fd5d01ff
    Reviewed-on: https://code.wireshark.org/review/3260
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit a68eab6ab57e2ba3dff5f49a90cdf9bd81a45f0a)
    Reviewed-on: https://code.wireshark.org/review/3815
    

Actions performed:

    from  74d8c02   packet-mausb.c: proto-reg-handoff() fixes
    adds  dfc005a   Hack to fix RTP player progress line position


Summary of changes:
 ui/gtk/rtp_player.c |   57 ++++++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 52 insertions(+), 5 deletions(-)