Wireshark-commits: [Wireshark-commits] master-1.10 cb8d493: RPKI RTR: Wrong decoding of RPKI RTR En

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 25 Aug 2014 14:09:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cb8d493b516de88514af5c68ff459c602c9f3315
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

cb8d493 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    RPKI RTR: Wrong decoding of RPKI RTR End of Data PDU
    
    The decoding of the End of Data PDU ignores the Serial Number, i.e., the last 32 bit of this PDU. Instead of that the current dissector implementation starts to decode a new RTR PDU.
    
    Details of packet format see http://tools.ietf.org/html/rfc6810#section-5.8
    
    Found by Matthias Wählisch
    
    Bug: 10411
    Change-Id: I8451b5fbda18a034022b97ff442ddb2a2dabed7b
    Reviewed-on: https://code.wireshark.org/review/3832
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit f44e082fa8403023425e27b28cb295f4e40e34e6)
    Reviewed-on: https://code.wireshark.org/review/3834
    

Actions performed:

    from  846bcde   [Automatic manuf, services and enterprise-numbers update for 2014-08-24]
    adds  cb8d493   RPKI RTR: Wrong decoding of RPKI RTR End of Data PDU


Summary of changes:
 epan/dissectors/packet-rpki-rtr.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)