Wireshark-commits: [Wireshark-commits] master 9d6d192: Use expert info to report unknown TLV types.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 18 Aug 2014 19:30:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9d6d19254cd7e264fcc886ec24b505ebd6156109
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9d6d192 by Guy Harris (guy@xxxxxxxxxxxx):

    Use expert info to report unknown TLV types.
    
    Unless we plan to fill in all 256 entries in the TLV type table, and
    unless that's because all 256 types are valid, we should report unknown
    types with an expert info, not a dissector assertion.
    
    Change-Id: Ia6fca37ad6a5969caad3229abaf08a25e20ba992
    Reviewed-on: https://code.wireshark.org/review/3707
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a3cecb2   Don't use proto_tree_add_expert() with an item rather than a tree.
    adds  9d6d192   Use expert info to report unknown TLV types.


Summary of changes:
 epan/dissectors/packet-gsm_abis_oml.c |   23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)