Wireshark-commits: [Wireshark-commits] master 6a82672: Return 0, not -1, for "this isn't my type of

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 17 Aug 2014 23:03:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a8267270f57c11dd63b6ef6970074ab962da87b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6a82672 by Guy Harris (guy@xxxxxxxxxxxx):

    Return 0, not -1, for "this isn't my type of file".
    
    -1 means "I got an error reading this file, so there's no point in
    trying any more open routines".  It doesn't mean "I couldn't find any
    matching pattern in the text"; that's 0, for "this isn't my type of
    file, but keep trying".
    
    Change-Id: I9d2e8b8fe6720052cacf70f0bacdcbc1175202cc
    Reviewed-on: https://code.wireshark.org/review/3674
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  2d2ecfb   Fix TRILL LSP dissector
    adds  6a82672   Return 0, not -1, for "this isn't my type of file".


Summary of changes:
 wiretap/logcat_text.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)