[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cd02af56a1e39c66b44fd7957aff3b7b77a59e9d
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cd02af5 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate (almost all) proto_tree_add_text calls from ASN.1 dissectors.
    
    This mostly involved adding expert info capabilities to many of the dissectors so that they could correctly flag error conditions.
    
    Only remaining proto_tree_add_text calls are in H248.cnf, which has a convoluted way of using hf_ data to make its tree.
    
    Change-Id: I6412150c2ec1977d7fa38f3f0ed416680bdfb141
    Reviewed-on: https://code.wireshark.org/review/3500
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  bb15274   Update symbol lists.
    adds  cd02af5   Eliminate (almost all) proto_tree_add_text calls from ASN.1 dissectors.


Summary of changes:
 asn1/acse/packet-acse-template.c                 |   18 ++-
 asn1/ansi_map/packet-ansi_map-template.c         |   76 +++++++----
 asn1/ansi_tcap/packet-ansi_tcap-template.c       |   18 ++-
 asn1/atn-ulcs/packet-atn-ulcs-template.c         |   15 ++-
 asn1/charging_ase/charging_ase.cnf               |    2 +-
 asn1/charging_ase/packet-charging_ase-template.c |   11 ++
 asn1/cmip/packet-cmip-template.c                 |   16 ++-
 asn1/dap/dap.cnf                                 |    2 +-
 asn1/dap/packet-dap-template.c                   |   11 ++
 asn1/disp/packet-disp-template.c                 |   33 +++--
 asn1/dop/packet-dop-template.c                   |   24 ++--
 asn1/dsp/packet-dsp-template.c                   |   28 ++++-
 asn1/ftam/packet-ftam-template.c                 |   12 +-
 asn1/goose/packet-goose-template.c               |    4 +-
 asn1/gprscdr/gprscdr.cnf                         |    2 +-
 asn1/gprscdr/packet-gprscdr-template.c           |   11 ++
 asn1/gsm_map/gsm_map.cnf                         |   17 +--
 asn1/gsm_map/packet-gsm_map-template.c           |   24 ++--
 asn1/h225/h225.cnf                               |    9 +-
 asn1/h225/packet-h225-template.c                 |    4 +
 asn1/h245/h245.cnf                               |   40 ++++--
 asn1/h245/packet-h245-template.c                 |    5 +
 asn1/h248/packet-h248-template.c                 |   11 +-
 asn1/h450/packet-h450-template.c                 |   20 ++-
 asn1/h460/packet-h460-template.c                 |    2 -
 asn1/idmp/packet-idmp-template.c                 |   13 +-
 asn1/inap/inap.cnf                               |    7 +-
 asn1/inap/packet-inap-template.c                 |    2 +
 asn1/isdn-sup/packet-isdn-sup-template.c         |   26 ++--
 asn1/kerberos/kerberos.cnf                       |    2 +-
 asn1/kerberos/packet-kerberos-template.c         |   22 ++--
 asn1/ldap/ldap.cnf                               |   10 +-
 asn1/ldap/packet-ldap-template.c                 |   92 ++++++--------
 asn1/lte-rrc/lte-rrc.cnf                         |   19 ++-
 asn1/lte-rrc/packet-lte-rrc-template.c           |   20 +++
 asn1/mms/packet-mms-template.c                   |    4 +-
 asn1/p1/packet-p1-template.c                     |    8 +-
 asn1/pkcs12/packet-pkcs12-template.c             |   15 ++-
 asn1/pres/packet-pres-template.c                 |   22 ++--
 asn1/q932/packet-q932-template.c                 |   36 ++++--
 asn1/qsig/packet-qsig-template.c                 |   21 +++-
 asn1/ros/packet-ros-template.c                   |   19 ++-
 asn1/ros/ros.cnf                                 |   27 ++--
 asn1/snmp/packet-snmp-template.c                 |   82 ++++++------
 asn1/snmp/packet-snmp-template.h                 |    2 +-
 asn1/snmp/snmp.cnf                               |    9 +-
 asn1/spnego/packet-spnego-template.c             |   22 +++-
 asn1/sv/packet-sv-template.c                     |    4 +-
 asn1/t38/packet-t38-template.c                   |   17 ++-
 asn1/t38/t38.cnf                                 |    4 +-
 asn1/tcap/packet-tcap-template.c                 |    9 +-
 epan/dissectors/packet-acse.c                    |   26 ++--
 epan/dissectors/packet-ansi_map.c                |   86 ++++++++-----
 epan/dissectors/packet-ansi_tcap.c               |   28 +++--
 epan/dissectors/packet-atn-ulcs.c                |   19 ++-
 epan/dissectors/packet-charging_ase.c            |   23 +++-
 epan/dissectors/packet-cmip.c                    |   32 +++--
 epan/dissectors/packet-dap.c                     |   31 +++--
 epan/dissectors/packet-disp.c                    |   45 ++++---
 epan/dissectors/packet-dop.c                     |   32 +++--
 epan/dissectors/packet-dsp.c                     |   40 ++++--
 epan/dissectors/packet-ftam.c                    |   22 +++-
 epan/dissectors/packet-goose.c                   |   14 ++-
 epan/dissectors/packet-gprscdr.c                 |   23 +++-
 epan/dissectors/packet-gsm_map.c                 |  147 ++++++++++++----------
 epan/dissectors/packet-h225.c                    |   33 +++--
 epan/dissectors/packet-h245.c                    |  145 ++++++++++++---------
 epan/dissectors/packet-h248.c                    |   17 ++-
 epan/dissectors/packet-h450.c                    |   38 ++++--
 epan/dissectors/packet-h460.c                    |    6 +-
 epan/dissectors/packet-idmp.c                    |   23 ++--
 epan/dissectors/packet-inap.c                    |   35 +++---
 epan/dissectors/packet-isdn-sup.c                |   38 ++++--
 epan/dissectors/packet-kerberos.c                |   32 ++---
 epan/dissectors/packet-ldap.c                    |  114 ++++++++---------
 epan/dissectors/packet-lte-rrc.c                 |   49 +++++---
 epan/dissectors/packet-mms.c                     |   10 +-
 epan/dissectors/packet-p1.c                      |   22 ++--
 epan/dissectors/packet-pkcs12.c                  |   27 ++--
 epan/dissectors/packet-pktc.c                    |    4 +-
 epan/dissectors/packet-pres.c                    |   24 ++--
 epan/dissectors/packet-q932.c                    |   46 ++++---
 epan/dissectors/packet-qsig.c                    |   39 ++++--
 epan/dissectors/packet-ros.c                     |   80 +++++++-----
 epan/dissectors/packet-snmp.c                    |  107 ++++++++--------
 epan/dissectors/packet-snmp.h                    |    2 +-
 epan/dissectors/packet-spnego.c                  |   32 +++--
 epan/dissectors/packet-sv.c                      |   10 +-
 epan/dissectors/packet-t38.c                     |   43 ++++---
 epan/dissectors/packet-tcap.c                    |   21 ++--
 90 files changed, 1566 insertions(+), 928 deletions(-)