Wireshark-commits: [Wireshark-commits] master c10396d: Fix read-past-end-of-buffer in CUPS dissecto

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 8 Aug 2014 00:31:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c10396dbbf782a576bc1f9a931cf86090cec3878
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c10396d by Evan Huus (eapache@xxxxxxxxx):

    Fix read-past-end-of-buffer in CUPS dissector
    
    Even when the protocol specifies that a string ends in a null-terminator, there
    are packets which won't. Therefore:
    
    **the result of tvb_get_ptr SHALL NOT be treated as a null-terminated string**
    
    We need to post that in big neon lettering somewhere obvious.
    
    Bug: 10353
    Change-Id: Ie30cd13353a9830311e573e734dd89dc07622c98
    Reviewed-on: https://code.wireshark.org/review/3485
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  dea377b   Put setargv.obj back in the list of objects for mergecap.
    adds  c10396d   Fix read-past-end-of-buffer in CUPS dissector


Summary of changes:
 epan/dissectors/packet-cups.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)