Wireshark-commits: [Wireshark-commits] lts-1.8.2 e13dd1c: fix underflow in BER constrained bitstrin

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 6 Aug 2014 10:24:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e13dd1c8d17aa3460cf751cddaa1c6d982af60a6
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.8.2
Repository: wireshark

Commits:

e13dd1c by Evan Huus (evan.huus@xxxxxxxxxxxxxx):

    fix underflow in BER constrained bitstrings
    
    this can happen and cause invalid memory accesses with incorrectly-large padding
    values
    
    Conflicts:
    	epan/dissectors/packet-ber.c
    
    Bug:10187
    Change-Id: Ib9b2a2fa10766efb4d95d588f57354a56373c626
    Reviewed-on: https://code.wireshark.org/review/2328
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/3438
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  a2f977d   catapult,irda: Fix ASAN crashes due to buffer underrun
    adds  e13dd1c   fix underflow in BER constrained bitstrings


Summary of changes:
 epan/dissectors/packet-ber.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)