URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=06ba328fece3a5d80a0b2ab9d88fa021c49d20af
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
06ba328 by Peter Wu (peter@xxxxxxxxxxxxx):
Fix uninitialized session ticket
If the tvb contained too few data,
ssl_dissect_hnd_hello_ext_session_ticket would then allocate
session_ticket, but not initialize the contents. Fix this by adding a
check for the TVB length.
The same is done for ssl_dissect_hnd_new_ses_ticket. That might, or
might not, be necessary as proto_tree_add_item() is called with the
range. When tree is NULL, ssl is usually NULL too. For clarity (and to
avoid surprises in the future), add it anyway.
Bug: 10330
Change-Id: I469e97542542aaef4cbd660086bedf92ba1c0b6e
Reviewed-on: https://code.wireshark.org/review/3309
Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 9dc3d67 wmem: get rid of the allocator timing test
adds 06ba328 Fix uninitialized session ticket
Summary of changes:
epan/dissectors/packet-ssl-utils.c | 2 ++
1 file changed, 2 insertions(+)