Wireshark-commits: [Wireshark-commits] master 5234d4c: OK, try sorting the compiler options.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 3 Aug 2014 00:47:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5234d4c2d09bd60831b51761faab7fb2f6821b65
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5234d4c by Guy Harris (guy@xxxxxxxxxxxx):

    OK, try sorting the compiler options.
    
    Also, comment out the addition of -Wno-deprecated-declarations, as the
    CMake build doesn't use it.
    
    If this succeeds in making the autotools and CMake builds compile C code
    with the same -W and -f flags in the same order, that should eliminate
    at least one reason why the CMake build produces compiler warnings that
    the autotools build doesn't.
    
    Change-Id: I0eaeae91b8e3c39c53f502daef86c2d103c8bdab
    Reviewed-on: https://code.wireshark.org/review/3374
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  2dd2690   Note that the ...COMMON_FLAGS are for C and C++.
    adds  5234d4c   OK, try sorting the compiler options.


Summary of changes:
 CMakeLists.txt |    6 +++---
 configure.ac   |   22 ++++++++++++----------
 2 files changed, 15 insertions(+), 13 deletions(-)