Wireshark-commits: [Wireshark-commits] master ab9dc4f: Don't use capture_interface_list() in this d

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 25 Jul 2014 22:49:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ab9dc4f554058345f344f2ab37a68d9385a1edf8
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ab9dc4f by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use capture_interface_list() in this dialog.
    
    Instead, if we have no interfaces in global_capture_opts.all_ifaces, use
    the refreshLocalInterfaces() method of the main WiresharkApplication to
    try to fetch them; that way, if we do find interfaces, a signal will be
    emitted to cause the rest of the UI to reflect their arrival.
    
    Change-Id: I59077ef855127fd6bddaa40126c1835a659ffc30
    Reviewed-on: https://code.wireshark.org/review/3202
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  0492921   Replace lseek/fstat by ws_lseek64/ws_fstat64
    adds  ab9dc4f   Don't use capture_interface_list() in this dialog.


Summary of changes:
 ui/qt/capture_preferences_frame.cpp |   36 +++++++++++++++++------------------
 1 file changed, 17 insertions(+), 19 deletions(-)