Wireshark-commits: [Wireshark-commits] master 7344cfc: Have buffer_free() null out the buffer data

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 15 Jul 2014 23:23:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7344cfc78ff89603af6dec685ed968f5954e757d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7344cfc by Guy Harris (guy@xxxxxxxxxxxx):

    Have buffer_free() null out the buffer data pointer.
    
    That prevents some double-free issues (I got one when doing non-"Update
    list of packets in real time" captures, if I do one such capture and
    then another one).
    
    Change-Id: Ia08034d9d1640bad21b74960efade8926dbfc5de
    Reviewed-on: https://code.wireshark.org/review/3063
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  2c772e3   ssl: move decoder init from ClientKeyExchange to ChangeCipherSpec
    adds  7344cfc   Have buffer_free() null out the buffer data pointer.


Summary of changes:
 filetap/buffer.c |    3 ++-
 wiretap/buffer.c |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)