Wireshark-commits: [Wireshark-commits] master 7248c24: ssl: add missing valid handshake types

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 11 Jul 2014 04:32:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7248c24afcf94b2ec63cc8f2c7ab3acc443af418
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7248c24 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl: add missing valid handshake types
    
    The DTLS dissector duplicated a handshake types check, this has been
    eliminated. Convert HandshakeType and ContentType to enums to get the
    benefit of compiler-checked switch cases. Move these checks to
    ssl-utils.
    
    Two default cases could never be reached since the dissector returns
    immediately on an invalid ContentType.
    
    Also fixed misleading debugging messages.
    
    Change-Id: I07a2062564e073004dcc0401cd82538e5659fa0c
    Reviewed-on: https://code.wireshark.org/review/2978
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c7b45d0   GTK Remote Capturing
    adds  7248c24   ssl: add missing valid handshake types


Summary of changes:
 epan/dissectors/packet-dtls.c      |   71 +++++++-----------------------------
 epan/dissectors/packet-ssl-utils.c |   45 +++++++++++++++++++----
 epan/dissectors/packet-ssl-utils.h |   58 ++++++++++++++++-------------
 epan/dissectors/packet-ssl.c       |   47 +++++++-----------------
 4 files changed, 99 insertions(+), 122 deletions(-)