Wireshark-commits: [Wireshark-commits] master-1.12 0ab474c: Avoid sign-extending bytes before handi

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 11 Jul 2014 00:29:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0ab474c68d12ff8079b90f9813054f3f14233a58
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

0ab474c by Guy Harris (guy@xxxxxxxxxxxx):

    Avoid sign-extending bytes before handing them to <ctype.h> macros.
    
    Pointed out by the Visual Studio code analyzer.
    
    Change-Id: Idd429b4d0fb3db11ce171c3a5b38bdc55cc53c15
    Reviewed-on: https://code.wireshark.org/review/2988
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit b5d4128bee88b42cb32337a6343bb44574ff2f3a)
    Reviewed-on: https://code.wireshark.org/review/2989
    

Actions performed:

    from  8a47b3a   pre-commit: Add 'unset GREP_OPTIONS' (similar to Gerrit commit-msg)
    adds  0ab474c   Avoid sign-extending bytes before handing them to <ctype.h> macros.


Summary of changes:
 wiretap/catapult_dct2000.c |    2 +-
 wiretap/iseries.c          |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)