Wireshark-commits: [Wireshark-commits] master 5bfc21c: Clean up handling of missing functions.

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Jul 2014 21:03:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5bfc21cf9e42af13a8d1ad6eb545ab82cb7dbe9d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5bfc21c by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up handling of missing functions.
    
    With autotools, CMake, and nmake, if we have a function, #define
    HAVE_{function_name_in_all_caps}, otherwise don't #define it.
    
    If we provide our own version of a function in libwsutil, make sure we
    have a header that declares it, and *ONLY* include that header if
    HAVE_{function_name_in_all_caps} is *NOT* defined, so that we don't have
    the system declaration and our declaration colliding.
    
    Check for inet_aton, strncasecmp, and strptime with CMake, just as we do
    with autotools.
    
    Simplify the addition of {function_name_in_all_caps}_LO to libwsutil in
    autotools.
    
    Change-Id: Id5be5c73f79f81919a3a865324e400eca7b88889
    Reviewed-on: https://code.wireshark.org/review/2903
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  e649420   H264: mark a parameter as unused
    adds  5bfc21c   Clean up handling of missing functions.


Summary of changes:
 ConfigureChecks.cmake                              |   14 +++++-
 config.h.win32                                     |    9 +++-
 configure.ac                                       |   53 ++++++++------------
 editcap.c                                          |    2 +-
 epan/addr_resolv.c                                 |    2 +-
 epan/dissectors/packet-dcom.c                      |    2 +
 epan/dissectors/packet-lbmr.c                      |    4 +-
 epan/dissectors/packet-lbtrm.c                     |    4 +-
 epan/ftypes/ftype-time.c                           |    2 +-
 epan/tvbuff.c                                      |    2 +-
 text2pcap.c                                        |    4 +-
 ui/text_import.c                                   |    2 +-
 wsutil/Makefile.am                                 |   35 ++++---------
 wsutil/strncasecmp.c                               |    2 +
 .../packet-ieee802a.h => wsutil/strncasecmp.h      |   11 ++--
 wsutil/strptime.c                                  |    4 ++
 16 files changed, 76 insertions(+), 76 deletions(-)
 copy epan/dissectors/packet-ieee802a.h => wsutil/strncasecmp.h (80%)