Wireshark-commits: [Wireshark-commits] master 2211813: Add logic to config.nmake to find 64-bit cyg

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 1 Jul 2014 19:18:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2211813e2190007b42e4385e06c5d10959f74e75
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2211813 by Tim Furlong (tim.furlong@xxxxxxxxx):

    Add logic to config.nmake to find 64-bit cygwin, and a note warning
    about forward slashes in the QT5_BASE_PATH if the recommended qmake
    command is used; both of these issues will cause annoyingly non-
    obvious errors.
    
    Change-Id: I6f9a662969d1fc1887e75e8b0fde3520bbbea416
    Reviewed-on: https://code.wireshark.org/review/2749
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e1e7dd0   Fix the QT build on Qt 5.3 or later to use the windeployqt tool to copy the rquired Qt files into the runtime directory
    adds  2211813   Add logic to config.nmake to find 64-bit cygwin, and a note warning about forward slashes in the QT5_BASE_PATH if the recommended qmake command is used; both of these issues will cause annoyingly non- obvious errors.


Summary of changes:
 config.nmake |    9 +++++++++
 1 file changed, 9 insertions(+)