URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a87e292272e2275893695a3fc58ccb7f4625ecb6
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
a87e292 by Evan Huus (eapache@xxxxxxxxx):
Tighten the dump-glossary test.
1. The only indication we get of an out-of-order value string is a message on
STDERR, so check that and fail the test if STDERR wasn't empty.
2. This exposes an out-of-order value string in packet-stun.c; fix it.
3. This triggered the pre-commit hook on packet-stun.c, which noticed an API
error (ENC_ASCII -> ENC_ASCII|ENC_NA); fix that too.
Change-Id: I36f87a2a87b40537119562f22a7e3012716ff239
Lesson: automated testing/tooling is both wonderful and scary.
Reviewed-on: https://code.wireshark.org/review/2682
Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
Actions performed:
from 8d2eaaa If we have no fields, don't try to iterate through them.
adds a87e292 Tighten the dump-glossary test.
Summary of changes:
epan/dissectors/packet-stun.c | 4 ++--
test/suite-clopts.sh | 5 ++++-
2 files changed, 6 insertions(+), 3 deletions(-)