Wireshark-commits: [Wireshark-commits] master-1.12 224ab2d: Don't hide tcp option kind/len fields

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 20 Jun 2014 06:07:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=224ab2d9c1633869fc01b378ede3f1a70dc546ab
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

224ab2d by Evan Huus (eapache@xxxxxxxxx):

    Don't hide tcp option kind/len fields
    
    Hidden fields are deprecated, and we were hiding them inconsistently anyways.
    
    Bug:10211
    Change-Id: Iaf1576ae7bc04c0c0bd896c096b117f1b8af2e9e
    Reviewed-on: https://code.wireshark.org/review/2474
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit 80c070fb517a8c153278d936f0143e283adc01fb)
    Reviewed-on: https://code.wireshark.org/review/2475
    

Actions performed:

    from  4a5b04b   Don't crash when closing the Summary window if the file has been closed.
    adds  224ab2d   Don't hide tcp option kind/len fields


Summary of changes:
 epan/dissectors/packet-tcp.c |   54 ++++++++++++++----------------------------
 1 file changed, 18 insertions(+), 36 deletions(-)