Wireshark-commits: [Wireshark-commits] master 53594f3: Dissectors for totemnet and totemsrp protoco

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 19 Jun 2014 18:23:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=53594f34e499d309c66f56b22f373bf502802620
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

53594f3 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Dissectors for totemnet and totemsrp protocols implemented in corosync cluster engine.  Bug 3232.
    
    From Masatake YAMATO
    
    changes in patch3 (Masatake YAMATO):
    
      * Fix a typo(s/Sequnce/Sequence/)
      * Use variable len instead of a number literal
      * Put _U_ marker to length parameter of dissect_corosync_totemsrp_ip_address
      * Use tvb_report_length instread of tvb_length
    
    changes in patch5 (Masatake YAMATO):
    
      * packet-corosync-totemsrp.c: Adapt to new dissector_try_heuristic interface
    
        + pass hdtbl_entry argument to dissector_try_heuristic.
    
      * packet-corosync-totemnet.c: Initialize corosync_totemnet_port to 5405
    
    changes in patch6 (Masatake YAMATO):
    
      * packet-corosync-totemsrp.c: Use tvb_reported_length instead of tvb_length.
      * packet-corosync-totemsrp.c: Remove unnecessary trailing space in string literals.
    
      * packet-corosync-totemnet.c: Remove SVN Id tag in a comment.
    
    changes in patch8 (Masatake YAMATO):
    
      * packet-corosync-totemnet.c: Remove SVN Id tag in comment(again).
      * packet-corosync-totemsrp.c: Use val_to_str_const instead of val_to_str.
    
    changes in patch9 (Masatake YAMATO):
    
      * wsutil/sober128.[ch]: New files derived from packet-corosync-totemnet.c.
        Decryption code is moved here.
      * packet-corosync-totemnet.c: Remove all decryption code from this file.
    
    Change-Id: Id832d9c5ce1be1668c857c9bbf39e8a84c31880c
    Reviewed-on: https://code.wireshark.org/review/725
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  0b245a4   Use the same offset += rtnValue logic for all TLV types, instead of a special case for chassis, port & ttl. I've avoided using any mathematical checks even though tlv type vals increase linearly just in case they change in the future.
    adds  53594f3   Dissectors for totemnet and totemsrp protocols implemented in corosync cluster engine.  Bug 3232.


Summary of changes:
 epan/CMakeLists.txt                        |    2 +
 epan/dissectors/Makefile.common            |    2 +
 epan/dissectors/packet-corosync-totemnet.c |  525 +++++++++++++
 epan/dissectors/packet-corosync-totemsrp.c | 1168 ++++++++++++++++++++++++++++
 wsutil/CMakeLists.txt                      |    1 +
 wsutil/Makefile.common                     |    2 +
 wsutil/sober128.c                          |  911 ++++++++++++++++++++++
 wsutil/sober128.h                          |   44 ++
 8 files changed, 2655 insertions(+)
 create mode 100644 epan/dissectors/packet-corosync-totemnet.c
 create mode 100644 epan/dissectors/packet-corosync-totemsrp.c
 create mode 100644 wsutil/sober128.c
 create mode 100644 wsutil/sober128.h