Wireshark-commits: [Wireshark-commits] master c6007e8: We don't need -Werror=unknown-warning-option

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 18 Jun 2014 18:55:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c6007e8d26a5fc2471242fbe571bf52284beaae3
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c6007e8 by Guy Harris (guy@xxxxxxxxxxxx):

    We don't need -Werror=unknown-warning-option with Clang.
    
    check_c_compiler_flag checks for the message Clang prints for an unknown
    warning option ("unknown warning option '-WXXX'"), and fails if it's
    produced, so we don't need to force the compiler to fail by passing it
    -Werror=unknown-warning-option.
    
    (Yes, the CMake way of handling those annoying options is different from
    the way we do that in autotools - autotools adds flags to force errors,
    CMake checks for the warning messages - but that's OK.)
    
    Change-Id: I5c2e5d6f4826eba7048736d5134d20417778276a
    Reviewed-on: https://code.wireshark.org/review/2400
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  5e5e201   Another message from Clang for unknown -f and -m flags.
    adds  c6007e8   We don't need -Werror=unknown-warning-option with Clang.


Summary of changes:
 CMakeLists.txt |    6 ------
 1 file changed, 6 deletions(-)