Wireshark-commits: [Wireshark-commits] master 17a5526: fix underflow in BER constrained bitstrings

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Jun 2014 18:17:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=17a552666b50896a9b9dde8ee6a1052e7f9a622e
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

17a5526 by Evan Huus (evan.huus@xxxxxxxxxxxxxx):

    fix underflow in BER constrained bitstrings
    
    this can happen and cause invalid memory accesses with incorrectly-large padding
    values
    
    Bug:10187
    Change-Id: Ib9b2a2fa10766efb4d95d588f57354a56373c626
    Reviewed-on: https://code.wireshark.org/review/2325
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  c30df31   lua_pushstring takes a copy of its argument
    adds  17a5526   fix underflow in BER constrained bitstrings


Summary of changes:
 epan/dissectors/packet-ber.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)