Wireshark-commits: [Wireshark-commits] master-1.12 a95d0f1: Unify variable and identifier names acc

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Jun 2014 15:45:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a95d0f17cbdef9ff0ae49b51d54a8828b1c70302
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

a95d0f1 by Hannes Mezger (hannes.mezger@xxxxxxxxxxx):

    Unify variable and identifier names according to the UA specification
    
    - Rename Uri to NamespaceUri for clarity
    - Correct NsId to NsIndex
    - ByteString NodeIds are called 'Opaque'
    
    Change-Id: I622d408ef9e19a2a899906b4127bae497735d402
    Reviewed-on: https://code.wireshark.org/review/2121
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit ddc275c562805757d5d971ccc31ef47dbc6df4bc)
    Reviewed-on: https://code.wireshark.org/review/2168
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fb0266f   Do not handle P_Mul packet as ASCII string when calculating checksum.
    adds  a95d0f1   Unify variable and identifier names according to the UA specification


Summary of changes:
 plugins/opcua/opcua_application_layer.c |    2 +-
 plugins/opcua/opcua_simpletypes.c       |   38 +++++++++++++++----------------
 2 files changed, 20 insertions(+), 20 deletions(-)