Wireshark-commits: [Wireshark-commits] master a279fa7: Have ipmi "dissectors" register through the

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 16 Jun 2014 20:38:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a279fa7705b9baf3f6c779face3067b722c802b2
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a279fa7 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Have ipmi "dissectors" register through the build process instead of "manually"
    
    Change-Id: I6d6d32e8a1bc21dee9bf52b502e1a02e9511ecb2
    Reviewed-on: https://code.wireshark.org/review/2253
    Reviewed-by: Dmitry Bazhenov <dima_b@xxxxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  cf99e6b   packet-ipdc.c: proto_tree_add_text -> something filterable.
    adds  a279fa7   Have ipmi "dissectors" register through the build process instead of "manually"


Summary of changes:
 epan/CMakeLists.txt                     |   27 +++++++++++----------------
 epan/dissectors/Makefile.common         |   26 +++++++++++---------------
 epan/dissectors/packet-ipmi-app.c       |    4 +++-
 epan/dissectors/packet-ipmi-bridge.c    |    4 +++-
 epan/dissectors/packet-ipmi-chassis.c   |    4 +++-
 epan/dissectors/packet-ipmi-picmg.c     |    2 +-
 epan/dissectors/packet-ipmi-pps.c       |    2 +-
 epan/dissectors/packet-ipmi-se.c        |    2 +-
 epan/dissectors/packet-ipmi-storage.c   |    2 +-
 epan/dissectors/packet-ipmi-transport.c |    2 +-
 epan/dissectors/packet-ipmi-update.c    |    2 +-
 epan/dissectors/packet-ipmi-vita.c      |    2 +-
 epan/dissectors/packet-ipmi.c           |   23 +++++------------------
 epan/dissectors/packet-ipmi.h           |   13 ++-----------
 14 files changed, 45 insertions(+), 70 deletions(-)