Wireshark-commits: [Wireshark-commits] master df8c4bf: Capture Interfaces Dialog:

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 12 Jun 2014 05:55:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=df8c4bf2644d39d66613868256d918346d56aef8
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

df8c4bf by Irene Ruengeler (ruengeler@xxxxxxxxxxxxx):

    Capture Interfaces Dialog:
    
    - allow to change the interface options in the table
    - save the options to preferences when the dialog is left
    - add a field for setting a capture filter for all selected interfaces
    - add a "Compile BPF" button and a window to show the compiled filter output
    - try to address Alexis' and Evan's comments
    
    Change-Id: Ic1272e29183ec80e2d2f4b3e494c79dabe2c3b6f
    Reviewed-on: https://code.wireshark.org/review/1946
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  428c5b9   function to parse the usbpcap pseudo-header and fill the conversation struct
    adds  df8c4bf   Capture Interfaces Dialog:


Summary of changes:
 capture_opts.h                                     |    1 +
 capture_ui_utils.c                                 |   66 ++-
 capture_ui_utils.h                                 |    6 +
 epan/prefs.c                                       |    4 +
 epan/prefs.h                                       |    1 +
 image/status.qrc                                   |    1 +
 ui/qt/CMakeLists.txt                               |    3 +
 ui/qt/Makefile.am                                  |    2 +
 ui/qt/Makefile.common                              |    4 +
 ui/qt/QtShark.pro                                  |    3 +
 ui/qt/capture_interfaces_dialog.cpp                |  609 ++++++++++++++++----
 ui/qt/capture_interfaces_dialog.h                  |   49 +-
 ui/qt/capture_interfaces_dialog.ui                 |   83 +--
 ui/qt/compiled_filter_output.cpp                   |  115 ++++
 ui/qt/compiled_filter_output.h                     |   72 +++
 ...ort_pdu_dialog.ui => compiled_filter_output.ui} |   65 +--
 ui/qt/interface_tree.cpp                           |   25 +
 ui/qt/interface_tree.h                             |    1 +
 ui/qt/main_window.cpp                              |    4 +-
 ui/qt/main_window.h                                |    2 +
 ui/qt/main_window_slots.cpp                        |    7 +
 21 files changed, 915 insertions(+), 208 deletions(-)
 create mode 100644 ui/qt/compiled_filter_output.cpp
 create mode 100644 ui/qt/compiled_filter_output.h
 copy ui/qt/{export_pdu_dialog.ui => compiled_filter_output.ui} (54%)