Wireshark-commits: [Wireshark-commits] master-1.12 54a85ab: IPMI trace dissector

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 Jun 2014 13:32:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=54a85ab19bb3029cfa5e6999784bc65bff34dee1
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

54a85ab by U-beauty\bdn (dima_b@xxxxxxxxxxxxxxx):

    IPMI trace dissector
    
    Added KCS and TMode protocol dissectors.
    Request/response logic has been revised.
    Saved request data logic has been revised.
    Added Get Message command response dissector.
    Added missing PICMG command dissectors.
    Added new PICMG command dissectors.
    Added new PPS OEM command entries.
    Added VITA 46.11 command dissectors.
    
     From: Bill Meier:
     - refs to value_strings/range_strings in hf[] entries, by convention, should use VALS/RVALS macros;
     - refs to true_false_strings should use TFS(&...) macro.
       also: true_false_string definitions should not be defined as arrays.
     - remove some unneeded #includes (packet-ipmi.c).
     - Do some re-indentation.
     - Add editor-modelines as needed.
    
    bug: 10004
    Change-Id: Ib269b35784c0b70892d1e0111bcfb483ea64092c
    Reviewed-on: https://code.wireshark.org/review/1185
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 977a811217d2ce9853aeeac4e4e97167d35a94fb)
    Reviewed-on: https://code.wireshark.org/review/2117
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  6b57f77   Fix  Warn Dissector bug, protocol LPP, in packet 1: proto.c:3403:  failed assertion "DISSECTOR_ASSERT_NOT_REACHED" redifine FT of NavModel-GLONASS-ECEF/gloP1
    adds  54a85ab   IPMI trace dissector


Summary of changes:
 epan/CMakeLists.txt                     |    2 +
 epan/dissectors/Makefile.common         |    4 +-
 epan/dissectors/packet-ipmi-app.c       |  100 +-
 epan/dissectors/packet-ipmi-chassis.c   |   25 +-
 epan/dissectors/packet-ipmi-picmg.c     | 1602 +++++++++++++++++++++++++++++--
 epan/dissectors/packet-ipmi-pps.c       |  119 ++-
 epan/dissectors/packet-ipmi-se.c        |   55 +-
 epan/dissectors/packet-ipmi-session.c   |    8 +-
 epan/dissectors/packet-ipmi-storage.c   |   24 +-
 epan/dissectors/packet-ipmi-trace.c     |  479 +++++++++
 epan/dissectors/packet-ipmi-transport.c |   74 +-
 epan/dissectors/packet-ipmi-vita.c      | 1325 +++++++++++++++++++++++++
 epan/dissectors/packet-ipmi.c           | 1592 ++++++++++++++++++------------
 epan/dissectors/packet-ipmi.h           |  107 ++-
 wiretap/pcap-common.c                   |    5 +-
 wiretap/wtap.c                          |    3 +
 wiretap/wtap.h                          |    1 +
 17 files changed, 4603 insertions(+), 922 deletions(-)
 create mode 100755 epan/dissectors/packet-ipmi-trace.c
 create mode 100755 epan/dissectors/packet-ipmi-vita.c