Wireshark-commits: [Wireshark-commits] master 53c66a9: Bluetooth: Avoid using macro GPOINTER_TO_UIN

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 30 May 2014 11:26:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=53c66a9e08690168d539bd5f3506c6cdbc8f4dc9
Submitter: Michal Labedzki (michal.labedzki@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

53c66a9 by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    Bluetooth: Avoid using macro GPOINTER_TO_UINT()
    
    Fix warnings and try to inform user about unknown values in
    "Decode As".
    
    Also use define instead of magic number for Unknown L2CAP CIDs.
    
    Change-Id: Ie6f26a9e3330b84cef14bbf8861ffbdbdb789225
    Reviewed-on: https://code.wireshark.org/review/1880
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    

Actions performed:

    from  5742d2e   Bluetooth: L2CAP: Another fix for CIDs
    adds  53c66a9   Bluetooth: Avoid using macro GPOINTER_TO_UINT()


Summary of changes:
 epan/dissectors/packet-btavctp.c  |   24 +++++--
 epan/dissectors/packet-btavdtp.c  |   16 ++---
 epan/dissectors/packet-btl2cap.c  |  126 +++++++++++++++++++++++++++++--------
 epan/dissectors/packet-btl2cap.h  |    6 +-
 epan/dissectors/packet-btrfcomm.c |   52 ++++++++++++---
 5 files changed, 176 insertions(+), 48 deletions(-)