Wireshark-commits: [Wireshark-commits] master-1.12 8da17d1: Replace manual string handling with str

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 26 May 2014 12:21:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8da17d1a316e1460ac1f15616b74c60c5c70928b
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

8da17d1 by Evan Huus (eapache@xxxxxxxxx):

    Replace manual string handling with strbuf
    
    Much simpler and should probably fix bug 10121.
    Also add modelines.
    
    Bug:10121
    Change-Id: Ib92977e734ebe1b8529c7b6b41fbd81eac13b186
    Reviewed-on: https://code.wireshark.org/review/1758
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit 26840fa88fea22959c0038ff438f5b314a5452ea)
    Reviewed-on: https://code.wireshark.org/review/1801
    

Actions performed:

    from  97dc329   Fix [-Werror=clobbered] gcc warning
    adds  8da17d1   Replace manual string handling with strbuf


Summary of changes:
 epan/dissectors/packet-tr.c |   31 ++++++++++++++++++++-----------
 1 file changed, 20 insertions(+), 11 deletions(-)