URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=08ce84ebbe91eaaccd8bbf8c8d43c8cecfc7945a
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
08ce84e by Evan Huus (eapache@xxxxxxxxx):
Grab-bag of dead initializers and two actual bugs.
All caught by cppcheck. The two (semi)-interesting bugs are:
- in asn1/atn-cpdlc/packet-atn-cpdlc-template.c where the break statement should
have been inside the brace, causing potential control-flow weirdness with
exceptions
- in epan/dissectors/packet-ieee80211.c where the bounds check for tag_len did
not match the expert info given
Change-Id: Ie173fb8d917aabb9b4571435d671d6f16e1c7569
Reviewed-on: https://code.wireshark.org/review/1793
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
Actions performed:
from c4ead25 GSM RLC MAC: Do not skip too many lines of the CSN_DESCR when the field is missing
adds 08ce84e Grab-bag of dead initializers and two actual bugs.
Summary of changes:
asn1/atn-cm/packet-atn-cm-template.c | 6 +++---
asn1/atn-cpdlc/packet-atn-cpdlc-template.c | 6 +++---
epan/dissectors/packet-asterix.c | 7 ++-----
epan/dissectors/packet-atn-cm.c | 6 +++---
epan/dissectors/packet-atn-cpdlc.c | 6 +++---
epan/dissectors/packet-batadv.c | 4 ++--
epan/dissectors/packet-dcerpc-netlogon.c | 1 -
epan/dissectors/packet-dcerpc-nt.c | 2 +-
epan/dissectors/packet-dcp-etsi.c | 2 +-
epan/dissectors/packet-ieee80211.c | 4 ++--
epan/dissectors/packet-lisp.c | 20 ++++++++++----------
epan/dissectors/packet-mac-lte.c | 6 ++++--
epan/dissectors/packet-mongo.c | 2 +-
epan/dissectors/packet-openflow_v5.c | 1 -
14 files changed, 35 insertions(+), 38 deletions(-)