Wireshark-commits: [Wireshark-commits] master 2cfda31: Change the signature of dissector_try_heuris

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 21 May 2014 20:17:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2cfda31ff09893bd8c59acabc8faad7227f52ede
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2cfda31 by AndersBroman (anders.broman@xxxxxxxxxxxx):

    Change the signature of dissector_try_heuristic() to return hdtbl_entry
    which can be used to call the found heuristic dissector on the next pass.
    
    Introduce call_heur_dissector_direct() to be used to call a heuristic
    dissector which accepted the frame on the first pass.
    
    Change-Id: I524edd717b7d92b510bd60acfeea686d5f2b4582
    Reviewed-on: https://code.wireshark.org/review/1697
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bb01c7a   Remove extra parentheses.
    adds  2cfda31   Change the signature of dissector_try_heuristic() to return hdtbl_entry which can be used to call the found heuristic dissector on the next pass.


Summary of changes:
 asn1/atn-ulcs/atn-ulcs.cnf                  |    8 ++-
 asn1/atn-ulcs/packet-atn-ulcs-template.c    |    2 +-
 asn1/credssp/credssp.cnf                    |    3 +-
 asn1/credssp/packet-credssp-template.c      |    8 +--
 asn1/mpeg-pes/packet-mpeg-pes-template.c    |    6 ++-
 asn1/t125/t125.cnf                          |    7 ++-
 docbook/release-notes.asciidoc              |    3 ++
 epan/dissectors/packet-atn-ulcs.c           |   10 +++-
 epan/dissectors/packet-cip.c                |    5 +-
 epan/dissectors/packet-clnp.c               |    3 +-
 epan/dissectors/packet-credssp.c            |   15 +++---
 epan/dissectors/packet-dccp.c               |    5 +-
 epan/dissectors/packet-dtls.c               |    3 +-
 epan/dissectors/packet-epl.c                |    8 +--
 epan/dissectors/packet-eth.c                |    6 ++-
 epan/dissectors/packet-http.c               |    3 +-
 epan/dissectors/packet-ieee802154.c         |    4 +-
 epan/dissectors/packet-infiniband.c         |    8 +--
 epan/dissectors/packet-ip.c                 |    5 +-
 epan/dissectors/packet-iwarp-ddp-rdmap.c    |    4 +-
 epan/dissectors/packet-lbmc.c               |    5 +-
 epan/dissectors/packet-media.c              |    3 +-
 epan/dissectors/packet-mime-encap.c         |    3 +-
 epan/dissectors/packet-mpeg-pes.c           |    8 +--
 epan/dissectors/packet-mq.c                 |    3 +-
 epan/dissectors/packet-netbios.c            |    4 +-
 epan/dissectors/packet-ositp.c              |   37 +++++++------
 epan/dissectors/packet-pgm.c                |    3 +-
 epan/dissectors/packet-q931.c               |    3 +-
 epan/dissectors/packet-sccp.c               |    3 +-
 epan/dissectors/packet-sctp.c               |    5 +-
 epan/dissectors/packet-sercosiii.c          |    3 +-
 epan/dissectors/packet-sip.c                |    8 ++-
 epan/dissectors/packet-smb-direct.c         |    3 +-
 epan/dissectors/packet-smb-pipe.c           |   14 ++---
 epan/dissectors/packet-smb2.c               |    4 +-
 epan/dissectors/packet-soupbintcp.c         |    2 +
 epan/dissectors/packet-ssl.c                |    3 +-
 epan/dissectors/packet-stun.c               |    6 ++-
 epan/dissectors/packet-sua.c                |    4 +-
 epan/dissectors/packet-t125.c               |    9 ++--
 epan/dissectors/packet-tcp.c                |    5 +-
 epan/dissectors/packet-tipc.c               |    5 +-
 epan/dissectors/packet-turnchannel.c        |    3 +-
 epan/dissectors/packet-udp.c                |   39 +++++++-------
 epan/dissectors/packet-usb.c                |    3 +-
 epan/dissectors/packet-vines.c              |    6 ++-
 epan/dissectors/packet-websocket.c          |    3 +-
 epan/dissectors/packet-wsp.c                |   11 ++--
 epan/dissectors/packet-x25.c                |    3 +-
 epan/packet.c                               |   75 +++++++++++++++++++++++----
 epan/packet.h                               |   34 ++++++++----
 plugins/ethercat/packet-ethercat-datagram.c |    7 +--
 plugins/profinet/packet-dcerpc-pn-io.c      |    3 +-
 plugins/profinet/packet-pn-rt.c             |    3 +-
 55 files changed, 299 insertions(+), 150 deletions(-)