URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ea95c837fe62cb89ae7a0507e3ca437b822d658c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
ea95c83 by Jakub Zawadzki (darkjames@xxxxxxxxxxxx):
Introduce col_add_lstr(), use it instead of slower col_add_fstr.
We have callgrind benchmarks which shows that col_add_fstr() takes
5% of Ir count cause of formatting done in g_vsnprintf().
New col_add_lstr() can be used in few dissectors without much ugliness,
and it should be a little faster.
Change-Id: Ifddd951063dfd3a27c2a7da4dafce9b242c0472c
Reviewed-on: https://code.wireshark.org/review/1629
Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 2408297 lua: fix buffer underrun
adds ea95c83 Introduce col_add_lstr(), use it instead of slower col_add_fstr.
Summary of changes:
epan/column-utils.c | 48 ++++++++++++++++++++++++++++++++++++++++-
epan/column-utils.h | 4 ++++
epan/dissectors/packet-sip.c | 13 ++++++-----
epan/dissectors/packet-stun.c | 7 ++++--
epan/dissectors/packet-tcp.c | 8 +++++--
epan/dissectors/packet-udp.c | 6 ++++--
epan/dissectors/packet-vlan.c | 22 ++++++++++++++++---
7 files changed, 93 insertions(+), 15 deletions(-)