Wireshark-commits: [Wireshark-commits] master aa922b0: Try to fix stack-buffer-overflow caught by A

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 May 2014 02:38:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aa922b0624aaefa697b296c69f862c1c74864a2b
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

aa922b0 by Evan Huus (eapache@xxxxxxxxx):

    Try to fix stack-buffer-overflow caught by ASAN
    
    Use wmem_array_append rather than wmem_array_append_one to make sure the pointer
    types match up. _append_one automatically takes the address of its argument,
    which causes problems if that argument is already a pointer.
    
    Thanks to Alexis for catching this.
    
    Change-Id: Ie702bb2c776f9fcf31bd64073c756edd75d888e8
    Reviewed-on: https://code.wireshark.org/review/1657
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  7ba7612   STUN dissector: fix (soft) warning about tvb_length
    adds  aa922b0   Try to fix stack-buffer-overflow caught by ASAN


Summary of changes:
 epan/dissectors/packet-gvcp.c |   10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)