Wireshark-commits: [Wireshark-commits] master d13e139: Interpret DHCPv6 option 18 as a byte array.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 11 May 2014 07:28:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d13e1394b3793d8a7dbb1ea31766e2ee5091da97
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d13e139 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Interpret DHCPv6 option 18 as a byte array.  RFC 3315, section 22.18 strongly suggests that any other such interpretation is inappropriate:
    
       The Interface-ID SHOULD be considered an opaque value, with policies
       based on exact match only; that is, the Interface-ID SHOULD NOT be
       internally parsed by the server.
    
    This reverts the "Cable Lab specific" functionality added in SVN rev 32928, git rev a541950ca80207eb50ad0cb7cee29a384e76d2b0.
    
    bug:9877
    Change-Id: Id4a8cbd01ab3cd6d5a0a44aa2066ea395190f51a
    Reviewed-on: https://code.wireshark.org/review/1579
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  43bb76a   Function to calculate twos complement is quicker and hopefully better understandable.
    adds  d13e139   Interpret DHCPv6 option 18 as a byte array.  RFC 3315, section 22.18 strongly suggests that any other such interpretation is inappropriate:


Summary of changes:
 epan/dissectors/packet-dhcpv6.c |   21 +++------------------
 1 file changed, 3 insertions(+), 18 deletions(-)