Wireshark-commits: [Wireshark-commits] master 9a51c1e: Added check for MAUSB length being multiple

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 6 May 2014 19:51:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9a51c1e5306d0d5444096f62619ce8186794a29b
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9a51c1e by Sean O. Stalley (sean.stalley@xxxxxxxxx):

    Added check for MAUSB length being multiple of a DWORD.
    
    MAUSB Packets should always be sent in DWORDs. This means that the
    only valid values for the length field are multiples of 4.
    This patch adds an expert info check to flag length fields that are
    multiples of 4.
    
    Change-Id: Ifb793f82aed4c9fb09a12f6ea97087733b58d14a
    Reviewed-on: https://code.wireshark.org/review/1536
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  d73fc0b   Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
    adds  9a51c1e   Added check for MAUSB length being multiple of a DWORD.


Summary of changes:
 epan/dissectors/packet-mausb.c |    8 ++++++++
 1 file changed, 8 insertions(+)