Wireshark-commits: [Wireshark-commits] master-1.8 8ad08b9: Fix possible buffer overflow in col_appe

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 5 May 2014 18:20:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8ad08b956dcca3c490c5f6de70f5cdb5e35b30ce
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.8
Repository: wireshark

Commits:

8ad08b9 by Jakub Zawadzki (darkjames@xxxxxxxxxxxx):

    Fix possible buffer overflow in col_append_sep_fstr()
    
    After appending separator it might happen that len > max_len, in such case
    g_vsnprintf() will overflow the col_buf buffer.
    
    Change-Id: Ic5ff49d30e30509e835165c4cc7e72e31f92fd5f
    Reviewed-on: https://code.wireshark.org/review/1493
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit 984e52244f08d344a6979bf1405b3d730a388702)
    Reviewed-on: https://code.wireshark.org/review/1513
    

Actions performed:

    from  d072858   [Automatic manuf, services and enterprise-numbers update for 2014-05-04]
    adds  8ad08b9   Fix possible buffer overflow in col_append_sep_fstr()


Summary of changes:
 epan/column-utils.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)