Wireshark-commits: [Wireshark-commits] master 33586a0: OpenFlow 1.4 OXM field OXM_OF_IPV6_ND_SLL in

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 5 May 2014 15:26:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=33586a09d438e756068f5c08855ebc2cf7aaf4f3
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

33586a0 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    OpenFlow 1.4 OXM field OXM_OF_IPV6_ND_SLL incorrectly dissected (128 bits read instead of 48)
    
    Dissection of OXM_OF_IPV6_ND_SLL triggers "malformed packet" comment in packet list since it makes dissecting of further OXM fields impossible.
    
    It is possible that similar issue will be with OXM_OF_IPV6_ND_TLL since its dissecting is basically the same.
    
    Issue found by Viktor
    Closed-bug:10011
    
    Change-Id: I21b85cc0572ffdb8bb8b73cfae0db1d72219fe4b
    Reviewed-on: https://code.wireshark.org/review/1505
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ce282a7   OpenFlow 1.3 OXM field OXM_OF_IPV6_ND_SLL incorrectly dissected (128 bits read instead of 48)
    adds  33586a0   OpenFlow 1.4 OXM field OXM_OF_IPV6_ND_SLL incorrectly dissected (128 bits read instead of 48)


Summary of changes:
 epan/dissectors/packet-openflow_v5.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)