Wireshark-commits: [Wireshark-commits] master 266e0a9: Add an API for programmatically adding ESP S

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 30 Apr 2014 05:01:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=266e0a9275f75d420bc70c02c23c9b8607d793e5
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

266e0a9 by Martin Mathieson (martin.r.mathieson@xxxxxxxxxxxxxx):

    Add an API for programmatically adding ESP SAs (most likely from a private
    dissector).
    
    Also, speed up ESP decryption in several ways:
    - store gcrypt_cipher_hd in the SA struct, rather than continually
    open, setkey and close for each PDU
    - don't convert the key string from ascii to hex each time - do it upon
    during update callback and keep
    - do the decryption in-place, avoiding the need to allocate, memcpy and
    free a separate buffer for encrypted data
    - when matching addresses, avoid doing a strlen until after we check
    whether or not we're matching against "*"
    
    Change-Id: Ibb66663ec21326351abc761be78a0d57f7797fa5
    Reviewed-on: https://code.wireshark.org/review/1421
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  faec751   SVN --> GIT in a few places. Fixes Bug #10060.
    adds  266e0a9   Add an API for programmatically adding ESP SAs (most likely from a private dissector).


Summary of changes:
 epan/dissectors/packet-ipsec.c |  742 +++++++++++++++++++++++-----------------
 epan/dissectors/packet-ipsec.h |   13 +-
 2 files changed, 431 insertions(+), 324 deletions(-)