Wireshark-commits: [Wireshark-commits] master 748e0d4: Create the HTTP tree and set column info aft

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 25 Apr 2014 04:21:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=748e0d4221eabab207a350640ce3f526c73afde9
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

748e0d4 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Create the HTTP tree and set column info after we're assured it's HTTP.  Otherwise a bogus tree is created when HTTP2 traffic is found.  Also, COL_PROTOCOL and COL_INFO can be prematurely populated.
    
    Change-Id: I9f1c736baaeb86f9fab61601d79e79b4e3a16c38
    Reviewed-on: https://code.wireshark.org/review/1334
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  757db64   Don't use HTTP filter for DTLS decryption test as it's not really HTTP traffic (and a more discerning HTTP dissector will cause this to fail)
    adds  748e0d4   Create the HTTP tree and set column info after we're assured it's HTTP.  Otherwise a bogus tree is created when HTTP2 traffic is found.  Also, COL_PROTOCOL and COL_INFO can be prematurely populated.


Summary of changes:
 epan/dissectors/packet-http.c |   32 +++++++++++++++++++++-----------
 1 file changed, 21 insertions(+), 11 deletions(-)