Wireshark-commits: [Wireshark-commits] master cb8386c: Revert "Create the HTTP tree after we're ass

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Apr 2014 12:59:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cb8386c4de31978e0988ea10de25aa9c40e58834
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cb8386c by Evan Huus (eapache@xxxxxxxxx):

    Revert "Create the HTTP tree after we're assured it's HTTP.  Otherwise a bogus tree is created when HTTP2 traffic is found."
    
    It causes the DTLS decryption test suite to fail for some reason, and I don't have time/energy to investigate further, so we should probably revert it until that gets resolved.
    
    This reverts commit fc5d8db74dc473610b9fc6c0c4b571d4aa65264a.
    
    Change-Id: Iac9a7592047d2e080e380a70752efa076303e442
    Reviewed-on: https://code.wireshark.org/review/1297
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  f0e77aa   Add a cast to satisfy mac buildbot.
    adds  cb8386c   Revert "Create the HTTP tree after we're assured it's HTTP.  Otherwise a bogus tree is created when HTTP2 traffic is found."


Summary of changes:
 epan/dissectors/packet-http.c |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)