Wireshark-commits: [Wireshark-commits] master 6f0f612: Apply the fix for bug 3290 to proto_tree_add

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 21 Apr 2014 14:43:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6f0f6120e368e81b52d4810af6527551ad38b29b
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6f0f612 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Apply the fix for bug 3290 to proto_tree_add_bytes*(): check the item length before trying to fake the item.
    
    This fixes the case described in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9983
    
    proto_tree_add_bytes_item() and FT_UINT_BYTES both still need work.
    
    Change-Id: Ie421fed9e6dcecbc8b3eed1a57b3032d6ee043e8
    Reviewed-on: https://code.wireshark.org/review/1219
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  cc86596   Minor value table updates. See bug 9718.
    adds  6f0f612   Apply the fix for bug 3290 to proto_tree_add_bytes*(): check the item length before trying to fake the item.


Summary of changes:
 epan/proto.c |   15 +++++++++++++++
 1 file changed, 15 insertions(+)