Wireshark-commits: [Wireshark-commits] master 80011ec: Don't se_ allocate strings when mapping addr

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 19 Apr 2014 14:20:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=80011ec03c034cbebbe901eb4ded1242efe8fc78
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

80011ec by Guy Harris (guy@xxxxxxxxxxxx):

    Don't se_ allocate strings when mapping addresses to column strings.
    
    This should significantly reduce memory usage, without increasing the
    CPU time required to process a capture file in TShark or Wireshark.
    
    As a result, se_address_to_str() is no longer used; eliminate it.
    
    Fixes bug #9949.
    
    Change-Id: I65a112a426c82cc73a957b81384c765c3d14f2c3
    Reviewed-on: https://code.wireshark.org/review/1213
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  1d57459   Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
    adds  80011ec   Don't se_ allocate strings when mapping addresses to column strings.


Summary of changes:
 epan/addr_resolv.c    |   67 +++++++++++++++++++++----------------------------
 epan/address_to_str.c |   11 --------
 epan/column-utils.c   |   12 ++++++---
 epan/to_str.h         |    1 -
 tools/checkAPIs.pl    |    1 -
 5 files changed, 36 insertions(+), 56 deletions(-)