Wireshark-commits: [Wireshark-commits] master d51cac2: Fix "might be clobbered by 'longjmp' or 'vfo

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 17 Apr 2014 00:16:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d51cac21b15ba4bc6dae6d81a35bc06ccab8fbc2
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d51cac2 by Bill Meier (wmeier@xxxxxxxxxxx):

    Fix "might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]" warning from gcc 4.9
    
    Rework code related to TRY_SCSI_CDB_ALLOC_LEN macro to simplify and clarify same.
    Rename some vars to catch any incorrect usage.
    
    Change-Id: Ibf9465c5ce7670aa1147e0c311c37e582ece427a
    Reviewed-on: https://code.wireshark.org/review/1177
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    Tested-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  b9dd810   Make dissect_nbss() a bit more like tcp_dissect_pdus().
    adds  d51cac2   Fix "might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]" warning from gcc 4.9


Summary of changes:
 epan/dissectors/packet-scsi-mmc.c |  292 ++++++++++++++++++-------------------
 epan/dissectors/packet-scsi.c     |  208 +++++++++++++-------------
 epan/dissectors/packet-scsi.h     |   45 ++++--
 3 files changed, 277 insertions(+), 268 deletions(-)