Wireshark-commits: [Wireshark-commits] master b9dd810: Make dissect_nbss() a bit more like tcp_diss

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 16 Apr 2014 20:39:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b9dd810c4cfd263e066087490178ea5a242ce0c7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b9dd810 by Guy Harris (guy@xxxxxxxxxxxx):

    Make dissect_nbss() a bit more like tcp_dissect_pdus().
    
    Move some stuff out of dissect_nbss_packet() to dissect_nbss(), to make
    its main loop look a bit more like tcp_dissect_pdus()' main loop, and
    then pick up some changes from tcp_dissect_pdus().
    
    Also, have the "Length" field cover not only the field nominally
    designated as a length field, but also the low-order bit of the flags
    field, because that bit is really the 17th bit of a 17-bit length field
    (RFC 1002 even speaks of it in those terms).
    
    Change-Id: Ia95912163c23d482bfca6c026d92aadbd0ca8ac4
    Reviewed-on: https://code.wireshark.org/review/1175
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  4bee7a5   USB: fix 'Decode As' by USB Device functionality
    adds  b9dd810   Make dissect_nbss() a bit more like tcp_dissect_pdus().


Summary of changes:
 epan/dissectors/packet-nbns.c |  210 +++++++++++++++++++++--------------------
 1 file changed, 110 insertions(+), 100 deletions(-)