Wireshark-commits: [Wireshark-commits] master a838f10: You can't use proto_item_set_len() to make a

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 14 Apr 2014 21:53:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a838f1083c0988de0af77ceb94f4ee8e8cc00faa
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a838f10 by Guy Harris (guy@xxxxxxxxxxxx):

    You can't use proto_item_set_len() to make an item unknown-length.
    
    You also shouldn't use an item for one *element* of a structure to
    represent the entire structure.
    
    Fix both of those.
    
    Change-Id: Id1711238ebec02f135c404ac001aa51d783b3c69
    Reviewed-on: https://code.wireshark.org/review/1142
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  45143c6   Fix Argument with 'nonnull' attribute passed null found by Clang
    adds  a838f10   You can't use proto_item_set_len() to make an item unknown-length.


Summary of changes:
 epan/dissectors/packet-isis-lsp.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)